Return empty modules array when module command is not available #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacFJA
requested changes
Jul 9, 2022
| if (strpos($exception->getMessage(), 'unknown command') === false) { | ||
| throw $exception; | ||
| } | ||
| $modules = []; |
There was a problem hiding this comment.
It can return null directly, because the foreach will have nothing to run
Suggested change
| $modules = []; | |
| return null; |
| try { | ||
| $modules = $client->executeRaw('module', 'list') ?? []; | ||
| } catch (\Throwable $exception) { | ||
| if (strpos($exception->getMessage(), 'unknown command') === false) { |
There was a problem hiding this comment.
Yoda style test is used (see PHP-CS-Fixer error: https://github.com/MacFJA/php-redisearch/runs/7054519075?check_suite_focus=true)
Suggested change
| if (strpos($exception->getMessage(), 'unknown command') === false) { | |
| if (false === strpos($exception->getMessage(), 'unknown command')) { |
| $modules = $client->executeRaw('module', 'list') ?? []; | ||
| try { | ||
| $modules = $client->executeRaw('module', 'list') ?? []; | ||
| } catch (\Throwable $exception) { |
There was a problem hiding this comment.
\Throwable should be imported (see PHP-CS-Fixer error: https://github.com/MacFJA/php-redisearch/runs/7054519075?check_suite_focus=true)
Merged
|
Closing in favor of #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to a Redis server with limited rights the module command may not be available. Predis throws an exception and executing commands is not possible. This happend with Redis Enterprise Cloud server where Redisearch is available but the module command not.